Page MenuHomePhabricator

Replace Differential hard-coded status "<select />" with tokenizer
ClosedPublic

Authored by epriestley on Aug 11 2017, 3:13 PM.
Tags
None
Referenced Files
F19544757: D18393.id44207.diff
Jan 23 2026, 3:34 PM
F19544756: D18393.id.diff
Jan 23 2026, 3:34 PM
F19544755: D18393.id44234.diff
Jan 23 2026, 3:34 PM
F19544743: D18393.diff
Jan 23 2026, 3:12 PM
F19068923: D18393.id.diff
Nov 30 2025, 12:46 PM
F19064100: D18393.diff
Nov 29 2025, 8:12 PM
F18849919: D18393.id.diff
Oct 30 2025, 1:08 PM
F18846662: D18393.diff
Oct 29 2025, 8:25 PM
Subscribers
None
Tokens
"Cup of Joe" token, awarded by chad.

Details

Summary

Ref T2543. This updates the UI control in the web UI. Also:

  • This implicitly makes this queryable with the API (differential.revision.search); it previously was not.
  • This does NOT migrate existing saved queries. I'll do those in the next change, and hold this until it happens.
  • This will break some existing /differential/?status=XYZ links. For example, status=open now needs to be status=open(). I couldn't find any of these in the upstream, and I suspect these are rare in the wild (users would normally link directly to saved queries, not use URI query construction).
Test Plan

Screen Shot 2017-08-11 at 8.09.44 AM.png (155×412 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
status2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18005
Build 24181: Run Core Tests
Build 24180: arc lint + arc unit