Page MenuHomePhabricator

Increase strictness of URI parsing, rejecting URIs in the form "ssh://-flag"
ClosedPublic

Authored by epriestley on Aug 10 2017, 10:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 2:31 PM
Unknown Object (File)
Sun, Feb 9, 7:37 PM
Unknown Object (File)
Wed, Jan 29, 5:15 AM
Unknown Object (File)
Tue, Jan 28, 2:46 AM
Unknown Object (File)
Tue, Jan 28, 2:46 AM
Unknown Object (File)
Tue, Jan 28, 2:46 AM
Unknown Object (File)
Tue, Jan 28, 2:46 AM
Unknown Object (File)
Mon, Jan 27, 3:47 PM
Subscribers
None

Details

Summary

Ref T12961. See that task for discussion of the major attack we're responding to here.

  • Reject hosts beginning with "-". These are not legitimate.
  • Reject hosts beginning with ".". These are also not legitimate.
  • Tighten $ to \z. $ can match either "newline, end of string" or "end of string". \z matches ONLY "end of string". We don't want to match a newline, only "end of string" strictly.
  • We already that hosts otherwise contain only "reasonable" characters (letters, numbers, hyphens, and periods).
Test Plan
  • Added unit tests, ran unit tests.
  • Tried to set a repository URI to ssh://-oxyz/path with these changes, which worked previously; it no longer works.

Diff Detail

Repository
rPHU libphutil
Branch
uristrict
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17992
Build 24163: Run Core Tests
Build 24162: arc lint + arc unit