Page MenuHomePhabricator

Increase strictness of URI parsing, rejecting URIs in the form "ssh://-flag"
ClosedPublic

Authored by epriestley on Aug 10 2017, 10:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 16 2026, 3:23 PM
Unknown Object (File)
Apr 16 2026, 3:23 PM
Unknown Object (File)
Apr 16 2026, 3:21 PM
Unknown Object (File)
Mar 4 2026, 2:27 AM
Unknown Object (File)
Feb 17 2026, 10:52 PM
Unknown Object (File)
Jan 9 2026, 3:33 AM
Unknown Object (File)
Jan 4 2026, 4:23 PM
Unknown Object (File)
Jan 4 2026, 12:54 AM
Subscribers
None

Details

Summary

Ref T12961. See that task for discussion of the major attack we're responding to here.

  • Reject hosts beginning with "-". These are not legitimate.
  • Reject hosts beginning with ".". These are also not legitimate.
  • Tighten $ to \z. $ can match either "newline, end of string" or "end of string". \z matches ONLY "end of string". We don't want to match a newline, only "end of string" strictly.
  • We already that hosts otherwise contain only "reasonable" characters (letters, numbers, hyphens, and periods).
Test Plan
  • Added unit tests, ran unit tests.
  • Tried to set a repository URI to ssh://-oxyz/path with these changes, which worked previously; it no longer works.

Diff Detail

Repository
rPHU libphutil
Branch
uristrict
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17991
Build 24161: Run Core Tests
Build 24160: arc lint + arc unit