Page MenuHomePhabricator

Remove `bin/files purge` workflow
ClosedPublic

Authored by epriestley on Aug 10 2017, 1:11 PM.
Tags
None
Referenced Files
F13196762: D18384.diff
Sun, May 12, 11:32 PM
F13194010: D18384.id.diff
Sun, May 12, 8:47 PM
F13193725: D18384.id44183.diff
Sun, May 12, 5:15 PM
F13192030: D18384.id44183.diff
Sun, May 12, 4:14 AM
F13190272: D18384.id44188.diff
Sat, May 11, 9:04 AM
F13190039: D18384.id44188.diff
Sat, May 11, 7:16 AM
Unknown Object (File)
Fri, May 3, 6:59 AM
Unknown Object (File)
Mon, Apr 29, 5:47 PM
Subscribers
None

Details

Summary

Fixes T12948. See that task for substantial discussion and context. Briefly:

  • This workflow is very old, and won't work for large (>2GB) files.
  • This workflow has become more dangerous than it once was, and can fail in several ways that delete data and/or make recovery much more difficult (see T12948 for more discussion).
  • This was originally added in D6068, which is a bit muddled, but looks like "one install ran into a weird issue so I wrote a script for them"; this would be a Consulting/Support issue and not come upstream today. I can't identify any arguments for retaining this workflow there, at least.
Test Plan
  • Grepped for files purge, got nothing.
  • Grepped for purge, looked for anything that looked like instructions or documentation, got nothing.

I don't recall recommending anyone run this script in many years, and didn't even remember that it existed or what it did when T12948 was reported, so I believe it is not in widespread use.

Diff Detail

Repository
rP Phabricator
Branch
purge1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17978
Build 24143: Run Core Tests
Build 24142: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 10 2017, 1:22 PM
This revision was automatically updated to reflect the committed changes.