Don't force buttons to grey with PHUIInfoView
ClosedPublic
Actions

Authored by chad on Aug 6 2017, 4:54 PM.

Tags

None

Referenced Files

	F14691363: D18352.id44112.diff
	Tue, Jan 14, 7:12 AM

	Unknown Object (File)
	Mon, Jan 13, 1:12 AM

	Unknown Object (File)
	Wed, Jan 8, 2:22 PM

	Unknown Object (File)
	Mon, Dec 30, 3:38 AM

	Unknown Object (File)
	Sat, Dec 28, 6:08 PM

	Unknown Object (File)
	Fri, Dec 27, 2:04 PM

	Unknown Object (File)
	Thu, Dec 26, 10:48 PM

	Unknown Object (File)
	Wed, Dec 25, 3:08 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPfd3cb18fe4a4: Don't force buttons to grey with PHUIInfoView

Summary

I'd like to use red buttons.

Test Plan

Set a button to red in InfoView, see red button.

Diff Detail

Repository

rP Phabricator

Branch

info-view (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17929
Build 24080: Run Core Tests
Build 24079: arc lint + arc unit

Event Timeline

chad created this revision.Aug 6 2017, 4:54 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 6 2017, 4:54 PM

Harbormaster completed remote builds in B17929: Diff 44112.Aug 6 2017, 4:55 PM

epriestley accepted this revision.Aug 7 2017, 1:25 PM

This revision is now accepted and ready to land.Aug 7 2017, 1:25 PM

Closed by commit rPfd3cb18fe4a4: Don't force buttons to grey with PHUIInfoView (authored by chad, committed by chad). · Explain WhyAug 7 2017, 1:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIInfoView.php

1 line

Diff 44112

View Options

src/view/phui/PHUIInfoView.php

Don't force buttons to grey with PHUIInfoViewClosedPublicActions