Don't force buttons to grey with PHUIInfoView
ClosedPublic
Actions

Authored by chad on Aug 6 2017, 4:54 PM.

Tags

None

Referenced Files

	F13106412: D18352.diff
	Sat, Apr 27, 8:01 PM

	Unknown Object (File)
	Wed, Apr 24, 10:32 PM

	Unknown Object (File)
	Wed, Apr 17, 3:09 PM

	Unknown Object (File)
	Thu, Apr 11, 7:35 AM

	Unknown Object (File)
	Wed, Apr 3, 11:16 AM

	Unknown Object (File)
	Mar 29 2024, 11:40 AM

	Unknown Object (File)
	Mar 28 2024, 7:55 PM

	Unknown Object (File)
	Feb 20 2024, 3:02 PM

View All 80 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPfd3cb18fe4a4: Don't force buttons to grey with PHUIInfoView

Summary

I'd like to use red buttons.

Test Plan

Set a button to red in InfoView, see red button.

Diff Detail

Repository

rP Phabricator

Branch

info-view (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17929
Build 24080: Run Core Tests
Build 24079: arc lint + arc unit

Event Timeline

chad created this revision.Aug 6 2017, 4:54 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 6 2017, 4:54 PM

Harbormaster completed remote builds in B17929: Diff 44112.Aug 6 2017, 4:55 PM

epriestley accepted this revision.Aug 7 2017, 1:25 PM

This revision is now accepted and ready to land.Aug 7 2017, 1:25 PM

Closed by commit rPfd3cb18fe4a4: Don't force buttons to grey with PHUIInfoView (authored by chad, committed by chad). · Explain WhyAug 7 2017, 1:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIInfoView.php

1 line

Diff 44112

View Options

src/view/phui/PHUIInfoView.php

Don't force buttons to grey with PHUIInfoViewClosedPublicActions