Page MenuHomePhabricator
Differential D18292

Clean up dropdown carets
ClosedPublic
Actions

Authored by chad on Jul 28 2017, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 18, 4:32 PM
Unknown Object (File)
Thu, Feb 13, 2:58 AM
Unknown Object (File)
Sun, Feb 9, 4:30 AM
Unknown Object (File)
Sun, Feb 9, 4:30 AM
Unknown Object (File)
Sun, Feb 9, 4:30 AM
Unknown Object (File)
Sun, Feb 9, 4:30 AM
Unknown Object (File)
Fri, Feb 7, 3:31 AM
Unknown Object (File)
Tue, Feb 4, 12:12 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPea0db5aa9d57: Clean up dropdown carets
Summary

Adds dropdown carets to buttons more universally that are actually dropdowns.

Test Plan

Differential, Application Search, Diffusion. Mobile and Desktop.

Diff Detail

Repository
rP Phabricator
Branch
dropdown-icon (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17827
Build 23944: Run Core Tests
Build 23943: arc lint + arc unit

Event Timeline

chad created this revision.Jul 28 2017, 10:10 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJul 28 2017, 10:10 PM
epriestley accepted this revision.Jul 28 2017, 10:10 PM
This revision is now accepted and ready to land.Jul 28 2017, 10:10 PM
Harbormaster completed remote builds in B17827: Diff 43988.Jul 28 2017, 10:11 PM
Closed by commit rPea0db5aa9d57: Clean up dropdown carets (authored by chad, committed by chad). · Explain WhyJul 28 2017, 10:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
ponder/
view/
1 line
search/
controller/
2 lines
view/
phui/
52 lines
webroot/
rsrc/
css/
phui/
button/
2 lines

Diff 43988

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/ponder/view/PonderAnswerView.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
View Options

webroot/rsrc/css/phui/button/phui-button.css

Loading...
Phabricator · Built by Phacility