Page MenuHomePhabricator
Differential D18179

Fix an issue where repositories with hyphens could sort improperly in typeaheads
ClosedPublic
Actions

Authored by epriestley on Jul 3 2017, 2:27 PM.
Tags
None
Referenced Files
F15463469: D18179.diff
Tue, Apr 1, 11:50 PM
F15462721: D18179.id43734.diff
Tue, Apr 1, 5:08 PM
F15461203: D18179.id.diff
Tue, Apr 1, 6:08 AM
F15459697: D18179.id43733.diff
Mon, Mar 31, 3:16 PM
F15456088: D18179.diff
Sun, Mar 30, 6:58 AM
F15430293: D18179.diff
Mar 24 2025, 6:56 AM
F15396899: D18179.id43733.diff
Mar 16 2025, 4:49 PM
F15385151: D18179.id43733.diff
Mar 14 2025, 9:51 PM
View All Files
Subscribers
None

Details

Reviewers
chad
amckinley
Maniphest Tasks
T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first)
Commits
rPa6f018210466: Fix an issue where repositories with hyphens could sort improperly in typeaheads
Summary

Fixes T12894. See that task for discussion.

Test Plan
  • Created repositories abcdef, then abcdef-a through abcdef-f.
  • Before patch, awkward sort order.
  • After patch, query for abcdef hits abcdef first.
  • See T12894 for details and screenshots.

Diff Detail

Repository
rP Phabricator
Branch
repo1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17622
Build 23655: Run Core Tests
Build 23654: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
typeahead/
2 lines

Diff 43733

View Options

src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php

Loading...
Phabricator · Built by Phacility