Convert cluster/projects config options to newer modular structure
ClosedPublic
Actions

Authored by epriestley on Jun 27 2017, 5:05 PM.

Details

Reviewers

chad
amckinley

Maniphest Tasks

T12845: Convert remaining ancient configuration type classes to modern modular type classes

Commits

rPb46e2bb4cc6f: Convert cluster/projects config options to newer modular structure

Summary

Ref T12845. Converts the cluster and project config options to the new stuff; this is mostly just shifting boilerplate around.

Test Plan

Edited, deleted, and mangled these options from the web UI and CLI.

Diff Detail

Repository

rP Phabricator

Branch

config9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17590
Build 23613: Run Core Tests
Build 23612: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 27 2017, 5:05 PM

Harbormaster completed remote builds in B17590: Diff 43699.Jun 27 2017, 5:06 PM

amckinley accepted this revision.Jun 27 2017, 5:29 PM

This revision is now accepted and ready to land.Jun 27 2017, 5:29 PM

epriestley mentioned this in T12845: Convert remaining ancient configuration type classes to modern modular type classes.Jun 27 2017, 7:11 PM

Closed by commit rPb46e2bb4cc6f: Convert cluster/projects config options to newer modular structure (authored by epriestley, committed by epriestley). · Explain WhyJun 27 2017, 7:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

20 lines

applications/

config/

option/

PhabricatorClusterConfigOptions.php

4 lines

PhabricatorNotificationConfigOptions.php

2 lines

type/

PhabricatorConfigType.php

4 lines

notification/

config/

PhabricatorNotificationServersConfigOptionType.php

	PhabricatorNotificationServersConfigType.php
	PhabricatorNotificationServersConfigOptionType.php

32 lines

project/

config/

PhabricatorProjectColorsConfigOptionType.php

PhabricatorProjectColorsConfigType.php

14 lines

PhabricatorProjectConfigOptions.php

4 lines

PhabricatorProjectIconsConfigOptionType.php

PhabricatorProjectIconsConfigType.php

14 lines

search/

management/

PhabricatorSearchManagementWorkflow.php

2 lines

infrastructure/

cluster/

config/

PhabricatorClusterDatabasesConfigOptionType.php

	PhabricatorClusterDatabasesConfigType.php
	PhabricatorClusterDatabasesConfigOptionType.php

24 lines

PhabricatorClusterSearchConfigOptionType.php

	PhabricatorClusterSearchConfigType.php
	PhabricatorClusterSearchConfigOptionType.php

17 lines

Diff 43699

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/option/PhabricatorClusterConfigOptions.php

View Options

src/applications/config/option/PhabricatorNotificationConfigOptions.php

View Options

src/applications/config/type/PhabricatorConfigType.php

View Options

src/applications/notification/config/PhabricatorNotificationServersConfigOptionType.php

View Options

src/applications/notification/config/PhabricatorNotificationServersConfigType.php

View Options

src/applications/project/config/PhabricatorProjectColorsConfigOptionType.php

View Options

src/applications/project/config/PhabricatorProjectColorsConfigType.php

View Options

src/applications/project/config/PhabricatorProjectConfigOptions.php

View Options

src/applications/project/config/PhabricatorProjectIconsConfigOptionType.php

View Options

src/applications/project/config/PhabricatorProjectIconsConfigType.php

View Options

src/applications/search/management/PhabricatorSearchManagementWorkflow.php

View Options

src/infrastructure/cluster/config/PhabricatorClusterDatabasesConfigOptionType.php

View Options

src/infrastructure/cluster/config/PhabricatorClusterDatabasesConfigType.php

View Options

src/infrastructure/cluster/config/PhabricatorClusterSearchConfigOptionType.php

View Options

src/infrastructure/cluster/config/PhabricatorClusterSearchConfigType.php

Convert cluster/projects config options to newer modular structureClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43699

src/__phutil_library_map__.php

src/applications/config/option/PhabricatorClusterConfigOptions.php

src/applications/config/option/PhabricatorNotificationConfigOptions.php

src/applications/config/type/PhabricatorConfigType.php

src/applications/notification/config/PhabricatorNotificationServersConfigOptionType.php

src/applications/notification/config/PhabricatorNotificationServersConfigType.php

src/applications/project/config/PhabricatorProjectColorsConfigOptionType.php

src/applications/project/config/PhabricatorProjectColorsConfigType.php

src/applications/project/config/PhabricatorProjectConfigOptions.php

src/applications/project/config/PhabricatorProjectIconsConfigOptionType.php

src/applications/project/config/PhabricatorProjectIconsConfigType.php

src/applications/search/management/PhabricatorSearchManagementWorkflow.php

src/infrastructure/cluster/config/PhabricatorClusterDatabasesConfigOptionType.php

src/infrastructure/cluster/config/PhabricatorClusterDatabasesConfigType.php

src/infrastructure/cluster/config/PhabricatorClusterSearchConfigOptionType.php

src/infrastructure/cluster/config/PhabricatorClusterSearchConfigType.php

Convert cluster/projects config options to newer modular structure
ClosedPublic
Actions

Revision Contents
Changeset List