Page MenuHomePhabricator

Move "wild" config types to new code
ClosedPublic

Authored by epriestley on Jun 27 2017, 1:59 PM.
Tags
None
Referenced Files
F15464112: D18164.id43709.diff
Wed, Apr 2, 6:32 AM
F15453916: D18164.id43697.diff
Sat, Mar 29, 3:04 PM
F15445521: D18164.id.diff
Thu, Mar 27, 2:20 PM
F15439885: D18164.diff
Wed, Mar 26, 10:02 AM
F15421833: D18164.id43697.diff
Sat, Mar 22, 2:29 AM
F15417210: D18164.id43709.diff
Thu, Mar 20, 4:02 PM
F15411094: D18164.diff
Wed, Mar 19, 8:49 AM
Unknown Object (File)
Feb 27 2025, 9:00 PM
Subscribers
None

Details

Summary

Ref T12845. This is the last of the hard-coded types.

These are mostly used for values which users don't directly edit, so it's largely OK that they aren't carefully validated. In some cases, it would be good to introduce a separate validator eventually.

Test Plan

Edited, deleted and mangled these values via the web UI and CLI.

Diff Detail

Repository
rP Phabricator
Branch
config7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17588
Build 23609: Run Core Tests
Build 23608: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 27 2017, 2:51 PM
This revision was automatically updated to reflect the committed changes.