Had some made, they seem better than my attempt.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12859: Some means of updating builtin images without a manual purge
- Commits
- rPcdeba0f85b40: New icons for repositories
review in sandbox.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- repo-icons (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 17544 Build 23540: Run Core Tests Build 23539: arc lint + arc unit
Event Timeline
Comment Actions
I have reviewed these icons for literally representing true objects in a factual way.
| resources/builtin/repo/building.png | ||
|---|---|---|
| 1 | what kind of building has 4-story vertical windows NOT VERY AUTHENTIC | |
| resources/builtin/repo/commit.png | ||
| 1 | Inner ring isn't AA'd properly? | |
| resources/builtin/repo/gears.png | ||
| 1 | Inner ring isn't AA'd properly. This gear is close enough to realistic that I'm not going to complain about it. | |
| resources/builtin/repo/locked.png | ||
| 1 | Inner ring isn't AA'd properly. | |
| resources/builtin/repo/microchip.png | ||
| 1 | I think this is perfectly identifiable, but the pins on a IC like the original are pin-shaped so they can go into sockets or holes in a circuit board or header:  This image reverses the direction of the pins and makes them point inward. It's identifiable as a CPU, but clearly an "artist's interpretation" of a CPU. FWIW I found this much worse one elsewhere on the internet:  | |
| resources/builtin/repo/repo.png | ||
| 1 | This book's pages are wider in the middle of the book than at the beginning and end. | |
Comment Actions
It's good the world of art has people like us to make sure icons directly represent real objects in a 1:1 way.
Comment Actions
I expect the white AA will be fixed in the next batch of icons. I don't believe it will affect anything.