Page MenuHomePhabricator

Pass all Throwables to Exception Handlers, not just Exceptions
ClosedPublic

Authored by epriestley on Jun 19 2017, 7:59 PM.
Tags
None
Referenced Files
F13325706: D18136.diff
Sat, Jun 15, 2:09 AM
F13300096: D18136.diff
Fri, Jun 7, 8:48 AM
F13281813: D18136.diff
Sun, Jun 2, 11:15 AM
F13269213: D18136.diff
Wed, May 29, 5:57 AM
F13254619: D18136.diff
Sat, May 25, 3:33 AM
F13247955: D18136.id43635.diff
Thu, May 23, 11:51 PM
F13240978: D18136.id43636.diff
Wed, May 22, 6:16 PM
F13239991: D18136.id43635.diff
Wed, May 22, 8:56 AM
Subscribers
None

Details

Summary

Ref T12855. PHP7 introduced "Throwables", which are sort of like super exceptions. Some errors that PHP raises at runtime have become Throwables instead of old-school errors now.

The major effect this has is blank pages during development under PHP7 for certain classes of errors: they skip all the nice "show a pretty error" handlers and

This isn't a compelete fix, but catches the most common classes of unexpected Throwable and sends them through the normal machinery. Principally, it shows a nice stack trace again instead of a blank page for a larger class of typos and minor mistakes.

Test Plan

Before: blank page. After:

Screen Shot 2017-06-19 at 12.51.23 PM.png (1×1 px, 277 KB)

Diff Detail

Repository
rP Phabricator
Branch
error1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17527
Build 23514: Run Core Tests
Build 23513: arc lint + arc unit

Event Timeline

See T12855 for some discussion of why we can't typehint Throwable -- it doesn't exist in PHP5, and we can't write handleException(ExceptionIfPHP5|ThrowableIfPHP7 $ex)

src/aphront/handler/AphrontRequestExceptionHandler.php
15–19

This had no callers, so I remove it.

This revision is now accepted and ready to land.Jun 20 2017, 3:58 AM
This revision was automatically updated to reflect the committed changes.