Page MenuHomePhabricator
Differential D18129

Move "List Inline Comments" to the inline header dropdown menu
ClosedPublic
Actions

Authored by epriestley on Jun 15 2017, 1:35 PM.
Tags
None
Referenced Files
F21692975: D18129.id43623.diff
Fri, Aug 7, 12:10 PM
F21692969: D18129.id43624.diff
Fri, Aug 7, 12:10 PM
Unknown Object (File)
Jun 23 2026, 3:58 AM
Unknown Object (File)
Mar 8 2026, 10:09 AM
Unknown Object (File)
Mar 4 2026, 1:26 PM
Unknown Object (File)
Mar 4 2026, 2:47 AM
Unknown Object (File)
Mar 4 2026, 2:47 AM
Unknown Object (File)
Mar 4 2026, 2:46 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8250: Would like to see all comments and their status in a list
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP9b93697d52f4: Move "List Inline Comments" to the inline header dropdown menu
Summary

See D18128. Ref T12733. Ref T8250.

Test Plan

Screen Shot 2017-06-15 at 5.31.34 AM.png (1×1 px, 516 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 15 2017, 1:35 PM
Harbormaster completed remote builds in B17515: Diff 43623.Jun 15 2017, 1:36 PM
chad accepted this revision.Jun 15 2017, 1:55 PM
This revision is now accepted and ready to land.Jun 15 2017, 1:55 PM
Closed by commit rP9b93697d52f4: Move "List Inline Comments" to the inline header dropdown menu (authored by epriestley, committed by epriestley). · Explain WhyJun 15 2017, 2:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
50 lines
src/
applications/
differential/
controller/
12 lines
view/
13 lines
webroot/
rsrc/
js/
application/
diff/
17 lines
differential/
3 lines
phuix/
10 lines

Diff 43624

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-populate.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXActionView.js

Loading...
Phabricator · Built by Phacility