Moves DiffusionTagsListView to uhhh, list. Separates out table view which is still in use now, implements mobile friendly UI for tags.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12824: Redesign Diffusion
- Commits
- rP6f7b31fbf8a5: Add a DiffusionTagListView
Review KDE's Krita repository locally with lots of tags, desktop and mobile.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- diff-tag-list (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17493 Build 23460: Run Core Tests Build 23459: arc lint + arc unit
Event Timeline
Comment Actions
It's a little odd to me that this has "History", but branches has "Compare". I would expect both branches and tags to support the same operations.
Comment Actions
oh i see, I linked history to the timestamp on the browse interface. I can button-ify that.
Comment Actions
I would personally say:
- The target of the link (stable) should possibly be history, not browse. This isn't how things work now, and isn't what GitHub does, but at least part of the old behavior was for consistency with the file lists, where the target of the link should "obviously" be browse, not history. Previously, file lists and branch lists appeared right next to one another with similar UI, so making them inconsistent could have been confusing. Since they're now more separate, I think there's a stronger argument for making "history" the default.
- I think offering "Compare" in both UIs is reasonable.
- I'm not sure we need "browse" from this UI at all. In cases where I'm interacting with branches I'm never concerned about what the repository looks like at the branch head: I believe I always care about the commit history.
Comment Actions
I think I've normalized all the views here ( History, Tags, Branches ) but if something sticks out as inconsistent or I mis-read any feedback, give a hollar.