Adds a very basic list of all inline comments, threaded, and their status. Kept this a little simpler than the mock, mostly because sorting here feels a little strange given threads would be all over the place. Not sure sorted is needed in practice anyways. I'd probably lean towards just adding a JS checkbox to hide certain rows if needed in the future.
Details
Details
- Reviewers
epriestley - Commits
- rP283a95d2aae0: Build a page for viewing all inline comments
Test various commenting structures:
- Leave Comment
- Update Diff
- Leave new comment
- Reply to comment
- Reply to comment as revision author
- Mark items as done
- Update diff again
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- arcpatch-D18112
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/controller/DifferentialRevisionInlinesController.php:147 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 17474 Build 23430: Run Core Tests Build 23429: arc lint + arc unit
Event Timeline
| src/applications/differential/controller/DifferentialRevisionInlinesController.php | ||
|---|---|---|
| 147 | Add the methods to PhabricatorInlineCommentInterface, then implement them in DifferentialInlineComment and PhabricatorAuditInlineComment. In both cases, the implementation will roughly be return $this->proxy->getDateWhatever(). | |
| 192 | Unused / no callers. | |
| 292 | Unused / no real callers. | |
| src/applications/differential/parser/DifferentialChangesetParser.php | ||
| 1047 | You could technically revert all these thread/reorder changes if you want. I think they're fine to keep (probably a very mild net positive for codebase quality?) but not used in this version of the change (these changes, plus the new PHUIDiffInlineThreader class). | |