Page MenuHomePhabricator

Send authorship information to Buildkite
Needs ReviewPublic

Authored by toolmantim on Jun 5 2017, 9:46 AM.
Tags
None
Referenced Files
F14379157: D18075.id43471.diff
Sat, Dec 21, 2:38 AM
Unknown Object (File)
Thu, Dec 19, 9:58 AM
Unknown Object (File)
Wed, Dec 18, 1:05 AM
Unknown Object (File)
Wed, Nov 27, 8:00 PM
Unknown Object (File)
Sat, Nov 23, 8:49 PM
Unknown Object (File)
Nov 21 2024, 3:06 AM
Unknown Object (File)
Nov 21 2024, 3:06 AM
Unknown Object (File)
Nov 21 2024, 2:46 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T12251. Currently the Buildkite API calls don't include any authorship information, making Buildkite's permission and notification system unusable for any builds triggered from Phabricator.

This probably wasn't noticed during initial development, as Buildkite will associate the build with the owner of the API key, so it probably appeared fine. But as soon as another user triggers a build plan, the Buildkite authorship information is incorrect.

This updates the Buildkite API call to include an "author" field containing the name and primary email address of the author of diffs and commits, which will allow Buildkite to match it against their list of verified email addresses and correctly associate builds.

Test Plan

Create a diff and a commit that trigger "Build with Buildkite" build plan steps. Verify the build author in the Buildkite interface shows the user name and email from Phabricator, and not the user that created the Buildkite API token.

Diff Detail

Repository
rP Phabricator
Branch
send-author-to-buildkite (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17385
Build 23307: arc lint + arc unit