Fix design atrocity
ClosedPublic
Actions

Authored by chad on May 30 2017, 9:28 PM.

Tags

None

Referenced Files

	F19083639: D18047.id.diff
	Dec 2 2025, 1:07 PM

	F19080688: D18047.id43404.diff
	Dec 2 2025, 2:09 AM

	F19075409: D18047.diff
	Dec 1 2025, 9:48 AM

	F19057455: D18047.id.diff
	Nov 28 2025, 10:36 PM

	F19017051: D18047.diff
	Nov 23 2025, 6:26 AM

	F19004959: D18047.diff
	Nov 21 2025, 1:18 PM

	F18831467: D18047.id.diff
	Oct 25 2025, 1:15 PM

	F18827391: D18047.diff
	Oct 24 2025, 9:50 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP87c59c086741: Fix design atrocity

Summary

So bad.

Test Plan

Reload notification search page.

Diff Detail

Repository

rP Phabricator

Branch

SIMPLE (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17317
Build 23205: Run Core Tests
Build 23204: arc lint + arc unit

Event Timeline

chad created this revision.May 30 2017, 9:28 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 30 2017, 9:28 PM

epriestley accepted this revision.May 30 2017, 9:28 PM

This revision is now accepted and ready to land.May 30 2017, 9:28 PM

Harbormaster completed remote builds in B17317: Diff 43404.May 30 2017, 9:29 PM

Closed by commit rP87c59c086741: Fix design atrocity (authored by chad, committed by chad). · Explain WhyMay 30 2017, 9:29 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a child revision: D18048: Make "simple" a "button type", not a "color".May 30 2017, 9:41 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

notification/

query/

PhabricatorNotificationSearchEngine.php

4 lines

Diff 43404

View Options

src/applications/notification/query/PhabricatorNotificationSearchEngine.php

Fix design atrocityClosedPublicActions