Differential D18044

Remove the ability to leave multi-line inline comments on touchscreen devices
ClosedPublic
Actions

Authored by epriestley on May 30 2017, 8:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rPcc0a6fd3aa45: Remove the ability to leave multi-line inline comments on touchscreen devices

Summary

Ref T12733. This ultimately conflicts with scrolling and took about two days to get reported as a bug/regression. See T12733 for a bunch of additional discussion. See T1026 for original discussion.

Test Plan

Left single-line and multi-line comments on desktop.
Tapped to leave single-line comments on mobile.
Dragged lines on mobile, got a scroll instead of a range comment.

Diff Detail

Repository

rP Phabricator

Branch

head2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17312
Build 23196: Run Core Tests
Build 23195: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2017, 8:37 PM

Harbormaster completed remote builds in B17312: Diff 43399.May 30 2017, 8:38 PM

chad accepted this revision.May 30 2017, 10:48 PM

This revision is now accepted and ready to land.May 30 2017, 10:48 PM

Closed by commit rPcc0a6fd3aa45: Remove the ability to leave multi-line inline comments on touchscreen devices (authored by epriestley, committed by epriestley). · Explain WhyMay 31 2017, 12:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

39 lines

Diff 43399

View Options

resources/celerity/map.php