Add needActiveDiffs to differential.createcomment method
ClosedPublic
Actions

Authored by chad on May 27 2017, 1:56 AM.

Details

Reviewers

epriestley
amckinley

Maniphest Tasks

T12766: Can't use `differential.createcomment` with message and action

Commits

rPe632db4fc0e9: (stable) Add needActiveDiffs to differential.createcomment method
rP3fb4ca2429b7: Add needActiveDiffs to differential.createcomment method

Summary

Ref T12766. Adds missing attachment for stacking actions in differential

Test Plan

Asked end user to verify patch.

Diff Detail

Repository

rP Phabricator

Branch

fix-diff-conduit (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17297
Build 23173: Run Core Tests
Build 23172: arc lint + arc unit

Event Timeline

chad created this revision.May 27 2017, 1:56 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 27 2017, 1:56 AM

reed added a subscriber: reed.May 27 2017, 1:56 AM

Harbormaster completed remote builds in B17297: Diff 43385.May 27 2017, 1:57 AM

ohkay

This revision is now accepted and ready to land.May 27 2017, 2:50 AM

chad requested review of this revision.May 27 2017, 2:51 AM

chad edited edge metadata.

epriestley accepted this revision.May 27 2017, 3:11 AM

This revision is now accepted and ready to land.May 27 2017, 3:11 AM

oh i requested review? im hiiiiiigh

Closed by commit rP3fb4ca2429b7: Add needActiveDiffs to differential.createcomment method (authored by chad, committed by chad). · Explain WhyMay 27 2017, 3:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialCreateCommentConduitAPIMethod.php

1 line

Diff 43385

View Options

src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php

Add needActiveDiffs to differential.createcomment methodClosedPublicActions