Differential D18029

Allow users to query feed by a date range
ClosedPublic
Actions

Authored by epriestley on May 26 2017, 5:24 PM.

Details

Reviewers

chad

Maniphest Tasks

T12762: Feed queries should support date range constraints

Commits

rP46a33c07dc0c: Allow users to query feed by a date range

Summary

Ref T12762.

Test Plan

Ran queries with start date, end date, both, neither.
Used EXPLAIN to try to make sure doing the bitshift isn't going to be a performance issue.

Screen Shot 2017-05-26 at 10.20.37 AM.png (1×1 px, 213 KB)

Diff Detail

Repository

rP Phabricator

Branch

feed3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17273
Build 23137: Run Core Tests
Build 23136: arc lint + arc unit

Event Timeline

epriestley created this revision.May 26 2017, 5:24 PM

Harbormaster completed remote builds in B17272: Diff 43361.May 26 2017, 5:25 PM

Add an error if you specify a bad date range (for example: 2015 to 2014, where the start and end dates are backwards).

Screen Shot 2017-05-26 at 10.26.44 AM.png (1×1 px, 153 KB)

Harbormaster completed remote builds in B17273: Diff 43362.May 26 2017, 5:29 PM

chad accepted this revision.May 26 2017, 6:44 PM

This revision is now accepted and ready to land.May 26 2017, 6:44 PM

Closed by commit rP46a33c07dc0c: Allow users to query feed by a date range (authored by epriestley, committed by epriestley). · Explain WhyMay 26 2017, 7:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

feed/

query/

PhabricatorFeedQuery.php

26 lines

PhabricatorFeedSearchEngine.php

30 lines

Diff 43362

View Options

src/applications/feed/query/PhabricatorFeedQuery.php