Page MenuHomePhabricator
Differential D18014

Migrate Project workboard background color to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 24 2017, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 4:57 PM
Unknown Object (File)
Sat, Dec 21, 1:34 AM
Unknown Object (File)
Dec 13 2024, 7:16 PM
Unknown Object (File)
Dec 11 2024, 5:03 AM
Unknown Object (File)
Dec 8 2024, 4:17 AM
Unknown Object (File)
Nov 28 2024, 4:18 AM
Unknown Object (File)
Nov 26 2024, 4:16 AM
Unknown Object (File)
Nov 24 2024, 5:45 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T12673: Update Projects for Modular Transactions
Commits
rP88466addee26: Migrate Project workboard background color to modular transactions
Summary

Removes now-unused method as well. Fixes T12673.

Test Plan

UI fiddling.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17239
Build 23082: Run Core Tests
Build 23081: arc lint + arc unit

Event Timeline

amckinley created this revision.May 24 2017, 7:54 PM
Herald added a subscriber: epriestley. · View Herald TranscriptMay 24 2017, 7:54 PM
epriestley accepted this revision.May 24 2017, 7:54 PM

v. nice

This revision is now accepted and ready to land.May 24 2017, 7:54 PM
Harbormaster completed remote builds in B17239: Diff 43327.May 24 2017, 7:55 PM
amckinley added inline comments.May 24 2017, 7:55 PM
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
56–60

I'm pretty sure (and a quick test seemed to confirm) that this code isn't needed with the way modular transactions work.

Closed by commit rP88466addee26: Migrate Project workboard background color to modular transactions (authored by amckinley, committed by amckinley). · Explain WhyMay 24 2017, 7:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
2 lines--
applications/
project/
controller/
3 lines1%
Loading...
editor/
58 lines76%
Loading...
storage/
19 lines4%
Loading...
xaction/
26 lines22%
Loading...

Diff 43327

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...
View Options

src/applications/project/xaction/PhabricatorProjectWorkboardBackgroundTransaction.php

Loading...
Phabricator · Built by Phacility