Unit tests pass. Went through the UI for creating new subprojects and milestones, but didn't setup some API calls to check that all the validation errors were still caught.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPcd136a6af86a: Migrate Project parent and milestone to modular transactions
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Skipped - Build Status
Buildable 17208 Build 23033: Run Core Tests Build 23032: arc lint + arc unit
Event Timeline
Comment Actions
- dangling comment
| src/applications/project/editor/PhabricatorProjectTransactionEditor.php | ||
|---|---|---|
| 284 | Typo! | |
| src/applications/project/editor/PhabricatorProjectTransactionEditor.php | ||
|---|---|---|
| 229 | A wild continue! | |
Comment Actions
Couple of tiny cleanups inline, nice catches.
| src/applications/project/editor/PhabricatorProjectTransactionEditor.php | ||
|---|---|---|
| 229 | Haha, this was definitely not intended/correct. | |
| 284 | 🐼 | |
| src/applications/project/xaction/PhabricatorProjectMilestoneTransaction.php | ||
| 23–25 | In this case, since we've already survived validation, you can safely executeOne() and skip the head(): $project = ...->executeOne(); We can't do that during validation because excuteOne() throws on permission errors. | |
| src/applications/project/xaction/PhabricatorProjectParentTransaction.php | ||
| 23–25 | (As above.) | |