Page MenuHomePhabricator

Migrate Project parent and milestone to modular transactions
ClosedPublic

Authored by amckinley on May 23 2017, 12:11 AM.
Tags
None
Referenced Files
F14405777: D17999.id43296.diff
Mon, Dec 23, 8:34 AM
Unknown Object (File)
Sat, Dec 21, 1:57 AM
Unknown Object (File)
Mon, Dec 9, 11:46 AM
Unknown Object (File)
Sun, Dec 8, 5:18 AM
Unknown Object (File)
Sat, Dec 7, 10:20 AM
Unknown Object (File)
Thu, Dec 5, 4:49 PM
Unknown Object (File)
Nov 19 2024, 1:56 AM
Unknown Object (File)
Nov 8 2024, 6:08 AM
Subscribers

Details

Test Plan

Unit tests pass. Went through the UI for creating new subprojects and milestones, but didn't setup some API calls to check that all the validation errors were still caught.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17201
Build 23021: Run Core Tests
Build 23020: arc lint + arc unit

Event Timeline

  • dangling comment
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
284

Typo!

src/applications/project/editor/PhabricatorProjectTransactionEditor.php
229

A wild continue!

Couple of tiny cleanups inline, nice catches.

src/applications/project/editor/PhabricatorProjectTransactionEditor.php
229

Haha, this was definitely not intended/correct.

284

🐼

src/applications/project/xaction/PhabricatorProjectMilestoneTransaction.php
23–25

In this case, since we've already survived validation, you can safely executeOne() and skip the head():

$project = ...->executeOne();

We can't do that during validation because excuteOne() throws on permission errors.

src/applications/project/xaction/PhabricatorProjectParentTransaction.php
23–25

(As above.)

This revision is now accepted and ready to land.May 23 2017, 6:00 PM
This revision was automatically updated to reflect the committed changes.