Page MenuHomePhabricator
Differential D17987

Add Revisions to User Profiles
ClosedPublic
Actions

Authored by chad on May 21 2017, 12:07 AM.
Tags
None
Referenced Files
F15430511: D17987.id.diff
Mon, Mar 24, 8:00 AM
F15428645: D17987.diff
Sun, Mar 23, 9:28 PM
F15422751: D17987.id43257.diff
Sat, Mar 22, 10:31 AM
F15421918: D17987.id43258.diff
Sat, Mar 22, 3:30 AM
F15412276: D17987.diff
Wed, Mar 19, 12:11 PM
F15407913: D17987.id.diff
Tue, Mar 18, 8:13 PM
F15400974: D17987.diff
Mon, Mar 17, 3:02 PM
F15396866: D17987.id.diff
Sun, Mar 16, 4:42 PM
View All Files
Subscribers
Korvin
Tokens
"Like" token, awarded by nfirmani.

Details

Reviewers
epriestley
Maniphest Tasks
T12423: Bring MenuItem customization options to User Profiles
Commits
rP11578bfc9009: Add Revisions to User Profiles
Summary

Ref T12423. Adds back revisions as a user profile page. I don't want to think about custom profiles for a while.

Test Plan

Make some diffs, visit my profile, see diffs.

Diff Detail

Repository
rP Phabricator
Branch
diff-profile (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17176
Build 22983: Run Core Tests
Build 22982: arc lint + arc unit

Event Timeline

chad created this revision.May 21 2017, 12:07 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 21 2017, 12:07 AM
Harbormaster completed remote builds in B17176: Diff 43257.May 21 2017, 12:08 AM
nfirmani awarded a token.May 21 2017, 4:15 AM
epriestley accepted this revision.May 21 2017, 11:13 AM
This revision is now accepted and ready to land.May 21 2017, 11:13 AM
epriestley added inline comments.May 21 2017, 12:13 PM
src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php
16–19

(You can omit this.)

25

Should be "Differential" appliation.

66–69

Can omit.

77

Needless / overwritten below?

chad added a comment.May 21 2017, 4:19 PM

derp

Closed by commit rP11578bfc9009: Add Revisions to User Profiles (authored by chad, committed by chad). · Explain WhyMay 21 2017, 4:24 PM
This revision was automatically updated to reflect the committed changes.
chad marked 2 inline comments as done.

Revision Contents
Changeset List

Diff 43257

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/application/PhabricatorPeopleApplication.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php

Loading...
View Options

src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php

Loading...
View Options

src/applications/people/menuitem/PhabricatorPeopleRevisionsProfileMenuItem.php

Loading...
Phabricator · Built by Phacility