Page MenuHomePhabricator
Differential D17987

Add Revisions to User Profiles
ClosedPublic
Actions

Authored by chad on May 21 2017, 12:07 AM.
Tags
None
Referenced Files
F17922416: D17987.diff
Wed, Jul 30, 6:46 AM
F17915389: D17987.id.diff
Tue, Jul 29, 8:35 PM
F17870433: D17987.diff
Mon, Jul 28, 1:56 PM
F17711894: D17987.diff
Thu, Jul 17, 9:18 AM
Unknown Object (File)
Jun 16 2025, 8:59 PM
Unknown Object (File)
Jun 16 2025, 8:59 PM
Unknown Object (File)
Jun 16 2025, 8:52 PM
Unknown Object (File)
Jun 16 2025, 7:58 PM
View All Files
Subscribers
Korvin
Tokens
"Like" token, awarded by nfirmani.

Details

Reviewers
epriestley
Maniphest Tasks
T12423: Bring MenuItem customization options to User Profiles
Commits
rP11578bfc9009: Add Revisions to User Profiles
Summary

Ref T12423. Adds back revisions as a user profile page. I don't want to think about custom profiles for a while.

Test Plan

Make some diffs, visit my profile, see diffs.

Diff Detail

Repository
rP Phabricator
Branch
diff-profile (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17176
Build 22983: Run Core Tests
Build 22982: arc lint + arc unit

Event Timeline

chad created this revision.May 21 2017, 12:07 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 21 2017, 12:07 AM
Harbormaster completed remote builds in B17176: Diff 43257.May 21 2017, 12:08 AM
nfirmani awarded a token.May 21 2017, 4:15 AM
epriestley accepted this revision.May 21 2017, 11:13 AM
This revision is now accepted and ready to land.May 21 2017, 11:13 AM
epriestley added inline comments.May 21 2017, 12:13 PM
src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php
16–19

(You can omit this.)

25

Should be "Differential" appliation.

66–69

Can omit.

77

Needless / overwritten below?

chad added a comment.May 21 2017, 4:19 PM

derp

Closed by commit rP11578bfc9009: Add Revisions to User Profiles (authored by chad, committed by chad). · Explain WhyMay 21 2017, 4:24 PM
This revision was automatically updated to reflect the committed changes.
chad marked 2 inline comments as done.

Revision Contents
Changeset List

Diff 43257

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/application/PhabricatorPeopleApplication.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileRevisionsController.php

Loading...
View Options

src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php

Loading...
View Options

src/applications/people/menuitem/PhabricatorPeopleRevisionsProfileMenuItem.php

Loading...
Phabricator · Built by Phacility