Page MenuHomePhabricator
Differential D17983

Show "objectives" UI only if prototypes are enabled
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 2:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 9:14 PM
Unknown Object (File)
Fri, Dec 13, 6:44 AM
Unknown Object (File)
Mon, Dec 2, 7:17 PM
Unknown Object (File)
Tue, Nov 26, 1:30 PM
Unknown Object (File)
Mon, Nov 25, 1:55 PM
Unknown Object (File)
Nov 21 2024, 8:37 AM
Unknown Object (File)
Nov 20 2024, 6:24 PM
Unknown Object (File)
Nov 16 2024, 3:55 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rP7ee20f573d4a: (stable) Show "objectives" UI only if prototypes are enabled
rPbdecff7d67ce: Show "objectives" UI only if prototypes are enabled
Summary

See D17955.

Test Plan

Loaded a revision, no longer saw annotations with prototypes off. Still saw annotations with prototypes on.

Diff Detail

Repository
rP Phabricator
Branch
mapx
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17153
Build 22956: Run Core Tests
Build 22955: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2017, 2:19 PM
Harbormaster completed remote builds in B17152: Diff 43242.May 20 2017, 2:20 PM
epriestley mentioned this in D17955: Add quest objectives to the minimap.May 20 2017, 2:22 PM
chad accepted this revision.May 20 2017, 2:36 PM
This revision is now accepted and ready to land.May 20 2017, 2:36 PM
epriestley updated this revision to Diff 43243.May 20 2017, 2:45 PM
epriestley retitled this revision from Completely disable the scrollbar annotation element on all systems to Show "objectives" UI only if prototypes are enabled.
epriestley edited the test plan for this revision. (Show Details)
  • Make it conditional on "show-prototypes" instead.
chad accepted this revision.May 20 2017, 2:46 PM
Harbormaster completed remote builds in B17153: Diff 43243.May 20 2017, 2:46 PM
Closed by commit rPbdecff7d67ce: Show "objectives" UI only if prototypes are enabled (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2017, 2:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
34 lines
src/
applications/
differential/
view/
4 lines
webroot/
rsrc/
js/
application/
diff/
10 lines
differential/
3 lines

Diff 43243

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-populate.js

Loading...
Phabricator · Built by Phacility