Show "objectives" UI only if prototypes are enabled
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 2:19 PM.

Details

Reviewers

Commits

rP7ee20f573d4a: (stable) Show "objectives" UI only if prototypes are enabled
rPbdecff7d67ce: Show "objectives" UI only if prototypes are enabled

Summary

See D17955.

Test Plan

Loaded a revision, no longer saw annotations with prototypes off. Still saw annotations with prototypes on.

Diff Detail

Repository

rP Phabricator

Branch

mapx

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17152
Build 22954: Run Core Tests
Build 22953: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2017, 2:19 PM

Harbormaster completed remote builds in B17152: Diff 43242.May 20 2017, 2:20 PM

epriestley mentioned this in D17955: Add quest objectives to the minimap.May 20 2017, 2:22 PM

chad accepted this revision.May 20 2017, 2:36 PM

This revision is now accepted and ready to land.May 20 2017, 2:36 PM

Make it conditional on "show-prototypes" instead.

chad accepted this revision.May 20 2017, 2:46 PM

Harbormaster completed remote builds in B17153: Diff 43243.May 20 2017, 2:46 PM

Closed by commit rPbdecff7d67ce: Show "objectives" UI only if prototypes are enabled (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2017, 2:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

application/

diff/

ScrollObjectiveList.js

3 lines

Diff 43242

View Options

resources/celerity/map.php