Page MenuHomePhabricator

Restore the "buoyant" header in Differential
ClosedPublic

Authored by epriestley on May 17 2017, 9:55 PM.
Tags
None
Referenced Files
F13237146: D17945.diff
Tue, May 21, 12:39 PM
F13236169: D17945.diff
Tue, May 21, 8:34 AM
F13214184: D17945.diff
Fri, May 17, 9:03 AM
F13208413: D17945.diff
Thu, May 16, 2:53 PM
F13192702: D17945.diff
Sun, May 12, 9:25 AM
Unknown Object (File)
Sun, May 5, 9:20 PM
Unknown Object (File)
Sun, Apr 28, 8:32 AM
Unknown Object (File)
Sun, Apr 28, 4:43 AM
Subscribers
None
Tokens
"Love" token, awarded by avivey."Dat Boi" token, awarded by ftdysa.

Details

Summary

Fixes T1591. This was removed long ago because it was a mess to implement and caused a bunch of weird issues, and also my tolerance for dealing with weird JS issues was much, much lower.

I have now survived the fires of JX.Scrollbar and would love to address 200 small nitpicks about obscure browser behaviors on Linux, so open the floodgates again.

A secondary goal here is to create room to add a global view state menu on the right, with 300 options like "hide all inlines", "hide done inlines", "hide collapsed inlines", "hide ghosts", "show ghosts", "enable filetree", "disable filetree", etc, etc. Not sure how much of this I'll actually do. I have one more experiment I want to try first.

Test Plan

Screen Shot 2017-05-17 at 2.38.36 PM.png (760×1 px, 114 KB)

Diff Detail

Repository
rP Phabricator
Branch
inline25
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17076
Build 22835: Run Core Tests
Build 22834: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 18 2017, 3:47 PM

I expect to keep tweaking this and receive 20 pieces of conflicting feedback about it, but I'm more confident we can make it stick now than I was in 2012.

This revision was automatically updated to reflect the committed changes.

I like this a lot and think we should expand it with more features (like, how many inlines are complete, etc).

tempted to make it inversely colored too

so many design possibilities