Moves this transaction over to modular transactions.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12625: Update Phriction for Modular Transactions
- Commits
- rPabc9bc77b27b: Move Phriction MOVE_TO transaction to Modular Transactions
Move a document, re-title a document, try to move over an existing document.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phriction-move-to (branched from master)
- Lint
Lint Passed Severity Location Code Message Advice src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php:93 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 17031 Build 22774: Run Core Tests Build 22773: arc lint + arc unit
Event Timeline
Comment Actions
Presumably this approach won't work with Conduit (since you can't pass a Document) but I don't think anything here puts us in a worse place than we were before.
(I'll try to go over this week's changes in more detail further in advance of the release cut so we have more time to fix anything I catch, since I really want to hit the release normally this week even though we're churning everything a lot.)
| src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php | ||
|---|---|---|
| 87 | Prefer if ($e_text !== null) -- otherwise, a translator can translate one of these errors as '' or "0" and bypass these checks. | |