Fixes T12626.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T12626: Update Pholio for Modular Transactions
- Commits
- rP6888472b567e: Migrate Pholio inline comments to modular transactions
Made lots of comments, confirmed no UI changes
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- pholio-dust (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17020 Build 22755: Run Core Tests Build 22754: arc lint + arc unit
Event Timeline
| src/applications/pholio/xaction/PholioMockInlineTransaction.php | ||
|---|---|---|
| 29–31 | I think you should be able to remove this: we should already automatically detect that transactions which apply comments have an effect (but maybe didn't when Pholio v1 was written). | |
| src/applications/pholio/xaction/PholioMockInlineTransaction.php | ||
|---|---|---|
| 29–31 | Not currently:  | |