Page MenuHomePhabricator

Retain keyboard cursor state across more inline edit operations in Differential
ClosedPublic

Authored by epriestley on May 16 2017, 2:31 PM.
Tags
None
Referenced Files
F15540422: D17905.diff
Fri, Apr 25, 7:27 AM
F15518154: D17905.diff
Sat, Apr 19, 11:27 AM
F15514940: D17905.id43075.diff
Fri, Apr 18, 6:42 AM
F15423734: D17905.id43075.diff
Mar 22 2025, 5:28 PM
F15421038: D17905.id43067.diff
Mar 21 2025, 8:31 PM
F15416575: D17905.id.diff
Mar 20 2025, 12:14 PM
F15415305: D17905.diff
Mar 20 2025, 5:16 AM
F15412516: D17905.diff
Mar 19 2025, 1:24 PM
Subscribers
None

Details

Summary

Ref T12634. Fixes T8131. Currently, most edit operations (edit, reply, collapse, mark done) lose the keyboard cursor state.

Instead, bind the state more tighlty to the inline object itself (instead of the rows which happen to be in the document), and then do a bit of recalculation to try to keep it selected across edits.

Test Plan
  • Used "n" to select an inline.
  • Clicked "Done" checkbox.
  • Pressed "n".
  • Went to the next inline (previously: lost position in document).
  • Behavior is also better for: edit, reply, collapse/expand.

Diff Detail

Repository
rP Phabricator
Branch
focus7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16995
Build 22721: Run Core Tests
Build 22720: arc lint + arc unit