Page MenuHomePhabricator
Differential D17895

Restore the Differential "edit" and "reply" keyboard shortcuts
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 12:33 AM.
Tags
None
Referenced Files
F15424107: D17895.id43056.diff
Sat, Mar 22, 8:13 PM
F15396302: D17895.diff
Sun, Mar 16, 1:22 PM
F15395715: D17895.id43038.diff
Sun, Mar 16, 9:11 AM
F15382993: D17895.id43039.diff
Fri, Mar 14, 3:11 PM
F15375049: D17895.id43039.diff
Wed, Mar 12, 9:23 PM
Unknown Object (File)
Mon, Mar 3, 6:22 AM
Unknown Object (File)
Feb 17 2025, 1:16 AM
Unknown Object (File)
Feb 16 2025, 10:32 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12616: Modernize display code for inline comments
Commits
rP2fb1edfeb198: Restore the Differential "edit" and "reply" keyboard shortcuts
Summary

Ref T12616. This makes "edit" and "reply" work again.

Test Plan

Used "e" and "r" to edit and reply.

Also used them in bogus ways and got useful UI feedback.

Diff Detail

Repository
rP Phabricator
Branch
inline14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16966
Build 22680: Run Core Tests
Build 22679: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
48 lines
src/
applications/
differential/
view/
8 lines
webroot/
rsrc/
js/
application/
diff/
9 lines
55 lines
25 lines

Diff 43039

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility