Page MenuHomePhabricator
Differential D17895

Restore the Differential "edit" and "reply" keyboard shortcuts
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 12:33 AM.
Tags
None
Referenced Files
F20313380: D17895.diff
Thu, Jun 11, 1:01 AM
Unknown Object (File)
Apr 12 2026, 1:09 PM
Unknown Object (File)
Apr 12 2026, 12:54 PM
Unknown Object (File)
Mar 6 2026, 3:45 AM
Unknown Object (File)
Mar 6 2026, 3:44 AM
Unknown Object (File)
Jan 16 2026, 6:49 AM
Unknown Object (File)
Jan 16 2026, 6:48 AM
Unknown Object (File)
Jan 14 2026, 6:44 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12616: Modernize display code for inline comments
Commits
rP2fb1edfeb198: Restore the Differential "edit" and "reply" keyboard shortcuts
Summary

Ref T12616. This makes "edit" and "reply" work again.

Test Plan

Used "e" and "r" to edit and reply.

Also used them in bogus ways and got useful UI feedback.

Diff Detail

Repository
rP Phabricator
Branch
inline14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16965
Build 22678: Run Core Tests
Build 22677: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
48 lines
src/
applications/
differential/
view/
8 lines
webroot/
rsrc/
js/
application/
diff/
9 lines
52 lines
25 lines

Diff 43038

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility