Page MenuHomePhabricator

Move most Differetial keyboard shortcuts into DiffChangesetList
ClosedPublic

Authored by epriestley on May 9 2017, 5:07 PM.
Tags
None
Referenced Files
F15414336: D17859.diff
Thu, Mar 20, 12:10 AM
F15379737: D17859.id.diff
Thu, Mar 13, 11:07 PM
F15379598: D17859.id43037.diff
Thu, Mar 13, 10:10 PM
Unknown Object (File)
Mon, Feb 24, 11:04 AM
Unknown Object (File)
Feb 3 2025, 9:43 AM
Unknown Object (File)
Jan 27 2025, 5:11 PM
Unknown Object (File)
Jan 25 2025, 10:04 PM
Unknown Object (File)
Jan 13 2025, 11:58 AM
Subscribers
None

Details

Summary

Ref T12616. This moves most keyboard shortcuts into DiffChangesetList. It breaks some shortcuts that I plan to restore later, noted in T12616 (toggle file, edit inline, reply to inline), since I think ripping them out now and rebuilding them in a little bit will make things much simpler.

Test Plan
  • Used j, k, n, p, J, K shortcuts to navigate a revision.

Diff Detail

Repository
rP Phabricator
Branch
inline13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16964
Build 22676: Run Core Tests
Build 22675: arc lint + arc unit