Page MenuHomePhabricator
Differential D17894

Move inline replies to new code and remove DifferentialInlineEditor
ClosedPublic
Actions

Authored by epriestley on May 15 2017, 11:49 PM.
Tags
None
Referenced Files
F19148688: D17894.id43054.diff
Dec 10 2025, 6:32 PM
F19146939: D17894.id43054.diff
Dec 10 2025, 3:53 PM
F19060190: D17894.diff
Nov 29 2025, 8:45 AM
F19059401: D17894.diff
Nov 29 2025, 5:17 AM
F18903219: D17894.id43054.diff
Nov 8 2025, 4:27 AM
F18868231: D17894.diff
Nov 4 2025, 5:23 AM
F18866181: D17894.id43054.diff
Nov 3 2025, 3:54 PM
F18768564: D17894.diff
Oct 8 2025, 4:15 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12616: Modernize display code for inline comments
Commits
rP41379f39debb: Move inline replies to new code and remove DifferentialInlineEditor
Summary

Ref T12616. This moves "reply" to the new stuff and deletes DifferentialInlineEditor, which no longer does anything.

(This breaks some keyboard shortcuts, but I'll rebase D17859 shortly.)

Test Plan

Replied to inlines; things seemed to work properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
75 lines
3 lines
src/
infrastructure/
diff/
13 lines
webroot/
rsrc/
js/
application/
diff/
12 lines
9 lines
61 lines
differential/
93 lines

Diff 43054

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
View Options

webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js

Loading...
Phabricator · Built by Phacility