Differential D17859

Move most Differetial keyboard shortcuts into DiffChangesetList
ClosedPublic
Actions

Authored by epriestley on May 9 2017, 5:07 PM.

Tags

None

Referenced Files

	F15451241: D17859.id.diff
	Fri, Mar 28, 8:57 PM

	F15426769: D17859.id43055.diff
	Sun, Mar 23, 10:46 AM

	F15421690: D17859.id42952.diff
	Sat, Mar 22, 1:37 AM

	F15421689: D17859.id.diff
	Sat, Mar 22, 1:37 AM

	F15421688: D17859.id43055.diff
	Sat, Mar 22, 1:37 AM

	F15421648: D17859.diff
	Sat, Mar 22, 1:31 AM

	F15414336: D17859.diff
	Thu, Mar 20, 12:10 AM

	F15379737: D17859.id.diff
	Thu, Mar 13, 11:07 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12616: Modernize display code for inline comments

Commits

rP588a66c04d03: Move most Differetial keyboard shortcuts into DiffChangesetList

Summary

Ref T12616. This moves most keyboard shortcuts into DiffChangesetList. It breaks some shortcuts that I plan to restore later, noted in T12616 (toggle file, edit inline, reply to inline), since I think ripping them out now and rebuilding them in a little bit will make things much simpler.

Test Plan

Used j, k, n, p, J, K shortcuts to navigate a revision.

Diff Detail

Repository

Branch

inline7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16878
Build 22539: Run Core Tests
Build 22538: arc lint + arc unit

Event Timeline

epriestley created this revision.May 9 2017, 5:07 PM

Harbormaster completed remote builds in B16878: Diff 42952.May 9 2017, 5:08 PM

chad accepted this revision.May 9 2017, 5:09 PM

This revision is now accepted and ready to land.May 9 2017, 5:09 PM

epriestley mentioned this in T12616: Modernize display code for inline comments.May 9 2017, 6:15 PM

epriestley mentioned this in D17894: Move inline replies to new code and remove DifferentialInlineEditor.May 15 2017, 11:49 PM

Rebase this on top of D17894; I'll restore missing shortcuts soon.

Harbormaster completed remote builds in B16964: Diff 43037.May 15 2017, 11:59 PM

Closed by commit rP588a66c04d03: Move most Differetial keyboard shortcuts into DiffChangesetList (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 1:23 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP41379f39debb: Move inline replies to new code and remove DifferentialInlineEditor.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

45 lines

1 line

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

1 line

view/

DifferentialChangesetListView.php

10 lines

diffusion/

controller/

DiffusionCommitController.php

2 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangeset.js

82 lines

DiffChangesetList.js

165 lines

differential/

behavior-keyboard-nav.js

Diff 42952

resources/celerity/map.php

Loading...

resources/celerity/packages.php

Loading...

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...

src/applications/differential/view/DifferentialChangesetListView.php

Loading...

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

Loading...