Page MenuHomePhabricator

Clean up some rough Macro transaction edges
ClosedPublic

Authored by chad on May 8 2017, 8:36 PM.
Tags
None
Referenced Files
F15382543: D17848.id42928.diff
Fri, Mar 14, 12:58 PM
Unknown Object (File)
Mon, Mar 3, 6:47 PM
Unknown Object (File)
Fri, Feb 21, 3:21 PM
Unknown Object (File)
Wed, Feb 19, 8:59 PM
Unknown Object (File)
Feb 16 2025, 3:18 PM
Unknown Object (File)
Feb 15 2025, 7:28 AM
Unknown Object (File)
Feb 9 2025, 3:59 AM
Unknown Object (File)
Feb 9 2025, 3:59 AM
Subscribers

Details

Summary

Ref T12685, cleans up various macro issues, remove subscribers, fix feed stories, etc.

Test Plan

Create a new macro, see no subscribers, edit various macros.

Diff Detail

Repository
rP Phabricator
Branch
macro-xaction-3 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16855
Build 22504: Run Core Tests
Build 22503: arc lint + arc unit

Event Timeline

  • fix edit with no macro?

One inline I'm not sure about, looks good otherwise.

src/applications/macro/editor/PhabricatorMacroEditEngine.php
75–76

GREAT comment A+++

src/applications/macro/xaction/PhabricatorMacroFileTransaction.php
13–15

What's this one for?

src/applications/macro/xaction/PhabricatorMacroFileTransaction.php
13–15

Editing a macro without changing the file generates an empty transaction instead of no transaction.

13–15

Specifically, it tries to set null, and the column isn't nullable.

Let me see if I can make FileEditField or whatever it is a little smarter about things.

If you put this on top of D17853, I think you can delete that if ($value) { bit and everything will just work better (not perfectly, but better).

This revision is now accepted and ready to land.May 8 2017, 11:28 PM
This revision was automatically updated to reflect the committed changes.