Page MenuHomePhabricator

Fix two Calendar availability cache issues
ClosedPublic

Authored by epriestley on May 1 2017, 5:40 PM.
Tags
None
Referenced Files
F13220492: D17809.diff
Sun, May 19, 1:33 AM
F13215830: D17809.id42825.diff
Fri, May 17, 8:11 PM
F13203418: D17809.diff
Tue, May 14, 11:43 PM
F13185093: D17809.diff
Sat, May 11, 2:35 AM
Unknown Object (File)
Tue, May 7, 4:57 AM
Unknown Object (File)
Fri, May 3, 2:20 AM
Unknown Object (File)
Mon, Apr 29, 1:44 PM
Unknown Object (File)
Wed, Apr 24, 9:55 PM
Subscribers
None

Details

Summary

Fixes T12661.

When changing the start date of an event from some time in the past to some time significantly in the future (more than 24 hours), we'd invalidate only future caches and leave users in an "away" state. Instead, just invalidate all past and future caches (this is simpler than trying to figure out a narrower window, and should not make us do too much extra work).

When uninviting users from events, their caches also didn't get cleared correctly. Instead, clear them.

Test Plan
  • Changed an event from "Apr 1 - June 1" to "May 15 - June 1", saw availablity clear properly.
  • Uninvited user @dog from an ongoing event, saw availability clear properly.

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16751
Build 22347: Run Core Tests
Build 22346: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 1 2017, 5:41 PM
This revision was automatically updated to reflect the committed changes.