Page MenuHomePhabricator
Create Task
Maniphest T12661

Changing start date on event didn't clear my away status
Closed, ResolvedPublic
Actions

Description

See E1486. I set the wrong start date and corrected it, but my status still seems tied to the task. Caching?

Revisions and Commits

rP Phabricator
D17809rP0ebe56be4086 Fix two Calendar availability cache issues

Related Objects

Mentioned Here
E1486: Italy

Event Timeline

chad created this task.May 1 2017, 5:09 PM
chad added projects: Calendar, Bug Report.
epriestley added a subscriber: epriestley.May 1 2017, 5:33 PM

I think we're too conservative about invalidating this cache. To reproduce:

  • Create an event from some time in the past to some time in the future.
  • Move the start date forward to at least 24+ hours past the current time.
  • Only caches with a TTL ahead of getStartDateTimeEpochForCache() get invalidated, but the start time epoch is now further in the future than the old cache.

We could invalidate ahead of the minimum of the old epoch and the new epoch, but I think it's probably simpler to invalidate unconditionally.

epriestley added a revision: D17809: Fix two Calendar availability cache issues.May 1 2017, 5:40 PM
epriestley closed this task as Resolved by committing rP0ebe56be4086: Fix two Calendar availability cache issues.May 1 2017, 5:43 PM
epriestley added a commit: rP0ebe56be4086: Fix two Calendar availability cache issues.
epriestley added a comment.May 1 2017, 5:48 PM

I cancelled and reinstated E1486 to force a cache clear with the new code, which seems to have resolved this in production.

Phabricator · Built by Phacility