Ref T12651. Ran into these during D17799:
- Use getStatusCode() to put the actual status code into the message.
- If we fail but wrote an empty file to reserve the filename, clean it up.
Details
Details
- Reviewers
chad amckinley - Maniphest Tasks
- T12651: Update `bin/host download` to use the newer API
- Commits
- rARC27b51e619237: Fix two minor issues with "arc download"
- Faked the error, phlog()'d the exception.
- Saw sensible exception message.
- Saw empty file get cleaned up.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- download1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16727 Build 22316: Run Core Tests Build 22315: arc lint + arc unit