Page MenuHomePhabricator

Put the keyboard focus reticle back on top of diffs
ClosedPublic

Authored by epriestley on Apr 24 2017, 10:21 AM.
Tags
None
Referenced Files
F14034453: D17784.diff
Sun, Nov 10, 12:22 AM
F14034268: D17784.diff
Sat, Nov 9, 11:22 PM
F13990458: D17784.diff
Tue, Oct 22, 3:45 AM
F13967771: D17784.id42764.diff
Wed, Oct 16, 3:50 PM
Unknown Object (File)
Sep 21 2024, 12:29 AM
Unknown Object (File)
Sep 4 2024, 5:20 AM
Unknown Object (File)
Aug 31 2024, 9:43 AM
Unknown Object (File)
Aug 31 2024, 7:18 AM
Subscribers
None

Details

Summary

Fixes T10954. This got hidden underneath things at some point.

Use pointer-events: none to make the mouse ignore the element so that hover/select/edit/click still work "through" the element.

Design could probably be improved here, maybe I'll make it more-visible when you press n and then have it fade quickly so it kind of gets out of your way once you find the block you want to read.

Test Plan

Screen Shot 2017-04-24 at 3.16.35 AM.png (259×1 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Branch
inline1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16688
Build 22258: Run Core Tests
Build 22257: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 24 2017, 5:12 PM
This revision was automatically updated to reflect the committed changes.