Page MenuHomePhabricator

Put the keyboard focus reticle back on top of diffs
ClosedPublic

Authored by epriestley on Apr 24 2017, 10:21 AM.
Tags
None
Referenced Files
F19827168: D17784.id.diff
Mon, Mar 9, 6:35 AM
F19827114: D17784.id42764.diff
Mon, Mar 9, 6:03 AM
F19749053: D17784.id42764.diff
Sun, Feb 15, 7:57 PM
F19690145: D17784.id.diff
Mon, Feb 9, 10:12 PM
F19643422: D17784.id42764.diff
Feb 5 2026, 9:24 PM
F19030939: D17784.id.diff
Nov 24 2025, 10:43 PM
F19030275: D17784.id.diff
Nov 24 2025, 8:39 PM
F19001795: D17784.diff
Nov 21 2025, 4:02 AM
Subscribers
None

Details

Summary

Fixes T10954. This got hidden underneath things at some point.

Use pointer-events: none to make the mouse ignore the element so that hover/select/edit/click still work "through" the element.

Design could probably be improved here, maybe I'll make it more-visible when you press n and then have it fade quickly so it kind of gets out of your way once you find the block you want to read.

Test Plan

Screen Shot 2017-04-24 at 3.16.35 AM.png (259×1 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Branch
inline1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16688
Build 22258: Run Core Tests
Build 22257: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 24 2017, 5:12 PM
This revision was automatically updated to reflect the committed changes.