Avoid failing when mail has no plain text part (Ref T12630)
Needs ReviewPublic
Actions

Authored by isfs on Apr 23 2017, 4:35 PM.

Tags

None

Referenced Files

	F13212733: D17781.diff
	Fri, May 17, 7:01 AM

	F13211075: D17781.diff
	Fri, May 17, 5:27 AM

	F13199130: D17781.diff
	Mon, May 13, 12:06 PM

	F13192296: D17781.id.diff
	Sun, May 12, 6:42 AM

	F13176687: D17781.id42746.diff
	Wed, May 8, 4:19 PM

	Unknown Object (File)
	Fri, May 3, 8:14 AM

	Unknown Object (File)
	Fri, May 3, 3:58 AM

	Unknown Object (File)
	Mon, Apr 29, 4:08 PM

View All 68 Files

Subscribers

epriestley

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part

Summary

Avoid failing when mail has no plain text part (Ref T12630)

Test Plan

Send mail with HTML only (no plain text part). Now Phabricator sends back an 'empty email' error instead of fatalling and bouncing via the mail system.

Diff Detail

Repository

rP Phabricator

Branch

stable

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16675
Build 22242: Run Core Tests
Build 22241: arc lint + arc unit

Event Timeline

isfs created this revision.Apr 23 2017, 4:35 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 23 2017, 4:35 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B16675: Diff 42746.Apr 23 2017, 4:36 PM

Revision Contents
Changeset List

Path

Size

scripts/

mail/

mail_handler.php

18 lines

Diff 42746

View Options

scripts/mail/mail_handler.php

Avoid failing when mail has no plain text part (Ref T12630)Needs ReviewPublicActions