Paths

Table of Contentst

Differential D17740

Move room preferences into own controller
ClosedPublic
Actions

Authored by chad on Apr 19 2017, 11:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 11:37 AM

	Unknown Object (File)
	Sun, Nov 17, 1:37 AM

	Unknown Object (File)
	Fri, Nov 1, 2:55 PM

	Unknown Object (File)
	Thu, Oct 24, 7:54 AM

	Unknown Object (File)
	Thu, Oct 24, 7:29 AM

	Unknown Object (File)
	Oct 18 2024, 7:16 PM

	Unknown Object (File)
	Oct 18 2024, 4:27 AM

	Unknown Object (File)
	Oct 16 2024, 2:20 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T12591: Dismantle ConpherenceUpdateController into more logical controllers

Commits

rP6969e9389f23: Move room preferences into own controller

Summary

Ref T12591. These preferences are per user and we need to reload the whole UI on a change anyways. Simplifies future expansion.

Test Plan

Option click into new window, set preferences. View in Conpherence, see saved settings, change sound. Hear new sound.

Diff Detail

Repository

Branch

move-conpherence-preferences (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16608
Build 22146: Run Core Tests
Build 22145: arc lint + arc unit

Event Timeline

chad created this revision.Apr 19 2017, 11:23 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 19 2017, 11:23 PM

Harbormaster completed remote builds in B16606: Diff 42671.Apr 19 2017, 11:24 PM

v. nice

src/applications/conpherence/controller/ConpherenceRoomPreferencesController.php
33	This can be simplified slightly to `$this->newDialog()` in modern code. Probably needs a `addCancelButton()`?
38	(Consider adding `getURI()` to `Thread` if it doesn't already exist?)

This revision is now accepted and ready to land.Apr 19 2017, 11:25 PM

update per comments

Harbormaster completed remote builds in B16608: Diff 42673.Apr 19 2017, 11:46 PM

Closed by commit rP6969e9389f23: Move room preferences into own controller (authored by chad, committed by chad). · Explain WhyApr 19 2017, 11:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

conpherence/

application/

PhabricatorConpherenceApplication.php

2 lines

constants/

ConpherenceUpdateActions.php

1 line

controller/

ConpherenceController.php

14 lines

ConpherenceRoomPreferencesController.php

104 lines

ConpherenceUpdateController.php

106 lines

storage/

ConpherenceThread.php

4 lines

Diff 42673

src/__phutil_library_map__.php

Loading...

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

Loading...

src/applications/conpherence/constants/ConpherenceUpdateActions.php

Loading...

src/applications/conpherence/controller/ConpherenceController.php

Loading...

src/applications/conpherence/controller/ConpherenceRoomPreferencesController.php

Loading...

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...

src/applications/conpherence/storage/ConpherenceThread.php

Loading...