Differential D17739

Make "Locate File" trigger when data loads if the user typed/pasted real fast
ClosedPublic
Actions

Authored by epriestley on Apr 19 2017, 11:12 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field

Commits

rPd2560b246201: Make "Locate File" trigger when data loads if the user typed/pasted real fast

Summary

Fixes T12599. If you're faster than the network request, we don't actually resolve your query when the data arrives.

Instead, when the data shows up, run the query if the user has typed something.

Test Plan

Pasted a filename in real fast, got results. (Previously: no results until you press something else.)

Diff Detail

Repository

rP Phabricator

Branch

locate

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16604
Build 22139: Run Core Tests
Build 22138: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 19 2017, 11:12 PM

Harbormaster completed remote builds in B16604: Diff 42669.Apr 19 2017, 11:13 PM

👍

This revision is now accepted and ready to land.Apr 19 2017, 11:13 PM

Closed by commit rPd2560b246201: Make "Locate File" trigger when data loads if the user typed/pasted real fast (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2017, 11:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

16 lines

webroot/

rsrc/

js/

application/

diffusion/

DiffusionLocateFileSource.js

5 lines

Diff 42669

View Options

resources/celerity/map.php