Page MenuHomePhabricator

Remove "participationStatus" from ConpherenceParticipant
ClosedPublic

Authored by epriestley on Apr 19 2017, 7:23 PM.
Tags
None
Referenced Files
F15436015: D17730.id42645.diff
Tue, Mar 25, 11:22 AM
F15392685: D17730.id.diff
Sat, Mar 15, 4:56 PM
F15390398: D17730.id42655.diff
Sat, Mar 15, 6:10 AM
F15389560: D17730.id.diff
Sat, Mar 15, 5:26 AM
F15375888: D17730.id42645.diff
Thu, Mar 13, 12:31 AM
Unknown Object (File)
Feb 27 2025, 2:10 AM
Unknown Object (File)
Feb 9 2025, 3:51 AM
Unknown Object (File)
Feb 9 2025, 3:51 AM
Subscribers
None

Details

Summary

Pathway to D17685. This column is a very complicated cache of: is participant.messageCount equal to thread.messageCount?

We can just ask this question with a JOIN instead and simplify things dramatically.

Test Plan
  • Ran migration.
  • Browsed around.
  • Sent a message, saw unread count go up.
  • Read the message, saw unread count go down.

Diff Detail

Repository
rP Phabricator
Branch
status2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16580
Build 22104: Run Core Tests
Build 22103: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 19 2017, 7:38 PM
This revision was automatically updated to reflect the committed changes.