Page MenuHomePhabricator
Differential D17730

Remove "participationStatus" from ConpherenceParticipant
ClosedPublic
Actions

Authored by epriestley on Apr 19 2017, 7:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 2:58 PM
Unknown Object (File)
Wed, Apr 24, 8:55 AM
Unknown Object (File)
Tue, Apr 23, 9:58 PM
Unknown Object (File)
Tue, Apr 23, 9:58 PM
Unknown Object (File)
Tue, Apr 23, 9:58 PM
Unknown Object (File)
Sun, Apr 21, 8:20 PM
Unknown Object (File)
Thu, Apr 11, 7:00 AM
Unknown Object (File)
Thu, Apr 11, 6:42 AM
View All 85 Files
Subscribers
None

Details

Reviewers
chad
Commits
rP0a335f91cdfb: Remove "participationStatus" from ConpherenceParticipant
Summary

Pathway to D17685. This column is a very complicated cache of: is participant.messageCount equal to thread.messageCount?

We can just ask this question with a JOIN instead and simplify things dramatically.

Test Plan
  • Ran migration.
  • Browsed around.
  • Sent a message, saw unread count go up.
  • Read the message, saw unread count go down.

Diff Detail

Repository
rP Phabricator
Branch
status2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16580
Build 22104: Run Core Tests
Build 22103: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 19 2017, 7:23 PM
Harbormaster completed remote builds in B16580: Diff 42645.Apr 19 2017, 7:24 PM
chad accepted this revision.Apr 19 2017, 7:38 PM
This revision is now accepted and ready to land.Apr 19 2017, 7:38 PM
Closed by commit rP0a335f91cdfb: Remove "participationStatus" from ConpherenceParticipant (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2017, 8:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
2 lines
applications/
conpherence/
constants/
controller/
5 lines
editor/
12 lines
query/
64 lines
storage/
16 lines
people/
cache/
3 lines

Diff 42645

View Options

resources/sql/autopatches/20170419.thread.02.status.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conpherence/constants/ConpherenceParticipationStatus.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceParticipantCountQuery.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceParticipant.php

Loading...
View Options

src/applications/people/cache/PhabricatorUserMessageCountCacheType.php

Loading...
Phabricator · Built by Phacility