Page MenuHomePhabricator

Remove "participationStatus" from ConpherenceParticipant
ClosedPublic

Authored by epriestley on Apr 19 2017, 7:23 PM.
Tags
None
Referenced Files
F18081503: D17730.id42655.diff
Tue, Aug 5, 12:42 AM
F18056633: D17730.id42645.diff
Mon, Aug 4, 8:42 AM
F17985352: D17730.id.diff
Fri, Aug 1, 8:44 PM
F17948862: D17730.diff
Thu, Jul 31, 10:11 PM
F17931177: D17730.diff
Wed, Jul 30, 6:41 PM
Unknown Object (File)
Jun 19 2025, 7:04 PM
Unknown Object (File)
Apr 25 2025, 6:35 AM
Unknown Object (File)
Apr 20 2025, 1:08 PM
Subscribers
None

Details

Summary

Pathway to D17685. This column is a very complicated cache of: is participant.messageCount equal to thread.messageCount?

We can just ask this question with a JOIN instead and simplify things dramatically.

Test Plan
  • Ran migration.
  • Browsed around.
  • Sent a message, saw unread count go up.
  • Read the message, saw unread count go down.

Diff Detail

Repository
rP Phabricator
Branch
status2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16580
Build 22104: Run Core Tests
Build 22103: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 19 2017, 7:38 PM
This revision was automatically updated to reflect the committed changes.