Paths

Table of Contentst

When a transaction has no quote ref, render "@user wrote:" properly
ClosedPublic
Actions

Authored by epriestley on Apr 18 2017, 4:07 PM.

Details

Reviewers

amckinley
chad

Maniphest Tasks

T12576: Quoting timeline objects without calling setQuoteRef() results in strings like "In null, <user> wrote"

Commits

rPe187519f00a0: When a transaction has no quote ref, render "@user wrote:" properly

Summary

Fixes T12576. In Javascript, data.ref is null, which is getting turned into /quote/?ref=null.

The code already handles this case, just not with ref=null happening in JS:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentQuoteController.php;b54adc6161c205e146fabb801ca53a44d94da444$47-52

Test Plan

Screen Shot 2017-04-18 at 9.04.32 AM.png (173×411 px, 11 KB)

Also quoted a normal comment on a normal object in a normal way.

Diff Detail

Repository

rP Phabricator

Branch

quoteref1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16550
Build 22055: Run Core Tests
Build 22054: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 18 2017, 4:07 PM

epriestley edited the test plan for this revision. (Show Details)Apr 18 2017, 4:07 PM

Harbormaster completed remote builds in B16550: Diff 42616.Apr 18 2017, 4:08 PM

chad accepted this revision.Apr 18 2017, 4:11 PM

This revision is now accepted and ready to land.Apr 18 2017, 4:11 PM

Closed by commit rPe187519f00a0: When a transaction has no quote ref, render "@user wrote:" properly (authored by epriestley, committed by epriestley). · Explain WhyApr 18 2017, 4:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

application/

transactions/

behavior-transaction-list.js

4 lines

Diff 42616

View Options

resources/celerity/map.php