Page MenuHomePhabricator
Differential D17697

Clean up remove participant language in Conpherence
ClosedPublic
Actions

Authored by chad on Apr 15 2017, 3:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 8:24 AM
Unknown Object (File)
Fri, May 3, 8:09 AM
Unknown Object (File)
Thu, Apr 25, 2:10 AM
Unknown Object (File)
Tue, Apr 23, 12:56 PM
Unknown Object (File)
Tue, Apr 23, 8:02 AM
Unknown Object (File)
Fri, Apr 19, 10:52 PM
Unknown Object (File)
Fri, Apr 19, 6:58 PM
Unknown Object (File)
Fri, Apr 12, 10:19 AM
View All 77 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPa56f9a1a5599: Clean up remove participant language in Conpherence
Summary

Updates the language to use "Remove Participant" instead of "Banish User"

Test Plan

Read through the various cases, test them by removing myself or others

Diff Detail

Repository
rP Phabricator
Branch
banish-conph (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16494
Build 21966: Run Core Tests
Build 21965: arc lint + arc unit

Event Timeline

chad created this revision.Apr 15 2017, 3:55 AM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 15 2017, 3:55 AM
Harbormaster completed remote builds in B16494: Diff 42561.Apr 15 2017, 3:56 AM
epriestley accepted this revision.Apr 15 2017, 12:29 PM

This is probably legitimately more clear anyway since this action is "kick" (remove temporarily; user can rejoin, not "ban" (banish permanently; user can not rejoin).

This revision is now accepted and ready to land.Apr 15 2017, 12:29 PM
Closed by commit rPa56f9a1a5599: Clean up remove participant language in Conpherence (authored by chad, committed by chad). · Explain WhyApr 15 2017, 4:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
controller/
8 lines

Diff 42561

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
Phabricator · Built by Phacility