Page MenuHomePhabricator

Add a failing test case for new Phortune account initialization
ClosedPublic

Authored by epriestley on Apr 14 2017, 4:53 PM.
Tags
None
Referenced Files
F18984908: D17691.id.diff
Nov 17 2025, 12:48 PM
F18854664: D17691.diff
Nov 1 2025, 12:25 AM
F18848070: D17691.id.diff
Oct 30 2025, 3:15 AM
F18785703: D17691.id42545.diff
Oct 14 2025, 9:58 AM
F18780674: D17691.id42551.diff
Oct 12 2025, 6:36 PM
F18777370: D17691.id.diff
Oct 11 2025, 2:32 AM
F18777183: D17691.id42551.diff
Oct 11 2025, 1:15 AM
F18777072: D17691.diff
Oct 11 2025, 12:48 AM
Subscribers
None

Details

Summary

Ref T12451. Ref T12484. I think D17657 fixed this, but caused the bug in D17690. The fix for that causes this bug again.

Put a unit test on it. This test currently fails; I'll correct the bug in the next change.

Test Plan

Ran arc unit, saw a failure.

Diff Detail

Repository
rP Phabricator
Branch
phortune3
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 16476
Build 21938: Run Core Tests
Build 21937: arc lint + arc unit

Unit TestsFailed

TimeTest
15 msPhabricatorPhortuneTestCase::Unknown Unit Message ("")
EXCEPTION (PhabricatorApplicationTransactionValidationException): Validation errors: - You can not remove yourself as an account manager. #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/phortune/storage/PhortuneAccount.php(51): PhabricatorApplicationTransactionEditor->applyTransactions(Object(PhortuneAccount), Array)
17 msPhabricatorPhortuneTestCase::Unknown Unit Message ("")
EXCEPTION (PhabricatorApplicationTransactionValidationException): Validation errors: - You can not remove yourself as an account manager. #0 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/phortune/storage/PhortuneAccount.php(51): PhabricatorApplicationTransactionEditor->applyTransactions(Object(PhortuneAccount), Array)
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
2 assertions passed.
View Full Test Results (2 Failed · 343 Passed)

Event Timeline

This revision is now accepted and ready to land.Apr 14 2017, 4:55 PM
This revision was automatically updated to reflect the committed changes.